Switch to com.widdindustries/cljc.java-time #37
Conversation
|
@oakmac I screwed up the JS part and I'm not familiar with that whole ecosystem, do you have time to take a peek? |
Sure! I will take a look sometime this week. |
|
I haven't had a chance to look back at this myself and was wondering if you'll find some time? |
I did briefly look at this last week, but am also very time constrained at the moment. I know that cljc.java-time depends on the JavaScript library js-joda, so the error that is currently showing on the latest CI build is likely a missing JS runtime dependency. |
|
I'll look into that, thanks for the pointer!
…On Mon, May 22, 2023 at 2:18 PM Chris Oakman ***@***.***> wrote:
I haven't had a chance to look back at this myself and was wondering if
you'll find some time?
I did briefly look at this last week, but am also very time constrained at
the moment.
I know that cljc.java-time <https://github.com/henryw374/cljc.java-time>
depends on the JavaScript library js-joda
<https://github.com/js-joda/js-joda>, so the error that is currently
showing on the latest CI build is likely a missing JS runtime dependency.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAM3NHJEOCYEOAUCASE2ULXHPJZPANCNFSM6AAAAAAXZAYPIM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
--
Howard M. Lewis Ship
Senior Staff Software Engineer at NuBank
|
|
I have opened PR-38 to this branch which fixes the CLJS deps issue 👍 Unfortunately, it created some new fun problems to solve before we merge + deploy this new version 🤣 |
import deps for ClojureScript
|
😁🎉 |
Fixes #31
I've sorted out a lot of the code changes, but I'm at a loss r.e. getting the JS tests to operate correctly.